Use separate directory for external dependencies (platform lib, CMOS parameter lib, etc)

[gavanderhoorn]

As per title.

This clearly separates those dependencies from MotoROS2 proper and additionally, prevents GCC from treating them as part of MotoROS2 itself.

Conversely, it prevents GCC from treating MotoROS2 sources as 'external', and thus disabling many of its checks and warnings.

[gavanderhoorn]

I was unsure as to whether this would work, but a test build (I've only tested the YRC1 configuration) seems to suggest it does.

@ted-miller: as you have more experience with this, could you please take a look?

I'm mostly trying to avoid the compiler marking the main src (project) directory as system, which then makes it ignore issues in that directory (which we don't want, obviously).

[ted-miller]

I'm mostly trying to avoid the compiler marking the main src (project) directory as system, which then makes it ignore issues in that directory (which we don't want, obviously)

What type of issues have you seen the compiler ignore?

[ted-miller]

I'm mostly trying to avoid the compiler marking the main src (project) directory as system

I have verified that the main project folder is passed with -I and not isystem.

[ted-miller]

I just did a batch build of all configurations and it worked fine. I'm just curious about the comment about the compiler ignoring issues.

[gavanderhoorn]

I'm doing some strange / unorthodox things locally which caused the src dir to be passed with -isystem instead of regular -I.

For normal use it doesn't really affect anything, but for the case(s) I describe having the external dependencies in a separate directory helps to avoid the -isystem.

It also doesn't seem to affect regular builds at all, so seems like a benign, if somewhat vaguely motivated, change.

[gavanderhoorn]

@ted-miller: just making sure: ok with me merging this?

[ted-miller]

Yep. All good.