Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 233-outside goal tolerance #241

Merged

Commits on May 14, 2024

  1. fix parsing of goal_tolerance entries in goal

    Don't assume all joints have associated tolerances, and deal with
    potentially out-of-order tolerance specifications (compared to order of
    joints MotoROS2 uses internally).
    yai-rosejo authored and gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    742e4fc View commit details
    Browse the repository at this point in the history
  2. refactor: make parsing stand-alone functions

    Easier to test and potentially to reuse.
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    dfe98ec View commit details
    Browse the repository at this point in the history
  3. always set default joint position tolerances

    Not just when there are no JointTolerance instances.
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d4e5c76 View commit details
    Browse the repository at this point in the history
  4. add tests for Parse_GoalPosTolerance(..)

    Note: they are appended to the main ActionServer_FJT source file as the function(s) tested are local to that compilation unit (ie: static).
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b385677 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    12699e4 View commit details
    Browse the repository at this point in the history
  6. make all tests static

    They're not needed outside this compilation unit.
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2917ef7 View commit details
    Browse the repository at this point in the history
  7. verify out array is of sufficient length

    Need space for at least the number of joint positions in the trajectory point.
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    35c8f85 View commit details
    Browse the repository at this point in the history
  8. clearer debug output

    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1464eca View commit details
    Browse the repository at this point in the history
  9. only check configured axes

    Instead of the maximum possible number always.
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c1f2c0e View commit details
    Browse the repository at this point in the history
  10. log doubles, not ints

    Work-around doesn't seem needed anymore.
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1cc7db7 View commit details
    Browse the repository at this point in the history
  11. emit warning about JointTolerances for unknown joints

    A debug log warning only right now. We could consider making it a fatal error and actually return it.
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c52dfa3 View commit details
    Browse the repository at this point in the history
  12. failure to parse tolerances fails traj execution

    This is a temporary implementation, as it would be better to check the goal_tolerance field can be parsed when validating a new goal.
    gavanderhoorn committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c552d58 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    c97a623 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Update src/ActionServer_FJT.c

    Co-authored-by: Ted Miller <[email protected]>
    gavanderhoorn and ted-miller authored May 20, 2024
    Configuration menu
    Copy the full SHA
    b73ad5d View commit details
    Browse the repository at this point in the history
  2. Update src/ActionServer_FJT.c

    Co-authored-by: Ted Miller <[email protected]>
    gavanderhoorn and ted-miller authored May 20, 2024
    Configuration menu
    Copy the full SHA
    2cb6115 View commit details
    Browse the repository at this point in the history