-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print the state of all configurable settings after parsing motoros2_config.yaml #81
Merged
ted-miller
merged 4 commits into
Yaskawa-Global:main
from
SejalBehere:Issue-33-Config-Loader-only-prints-parsed-items
Jul 10, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
da7e441
Update ConfigFile.c to Print the values of yaml keys at once
SejalBehere a8c7016
Update ConfigFile.c
SejalBehere 504a813
Merge branch 'Yaskawa-Global:main' into Issue-33-Config-Loader-only-p…
SejalBehere 31031a4
Update ConfigFile.c to print all the contents of g_nodeConfigSettings
SejalBehere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this to its own function instead?
One of the earlier commits in this PR seems to have it had structured that way, but that was changed to this version instead. Was there a particular reason for that?
Perhaps something like
Ros_ConfigFile_DumpSettings(Ros_Configuration_Settings const* const settings)
?Additionally: is the idea we keep adding lines to this? It would have been ideal if somehow we could generalise the printing a bit and not rely on the developer to remember having to extend these prints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try to make this into a function and then call on it but it still wasn't printing out the values of all the elements of g_nodeConfigSettings so I tried this as an an alternate solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how you would do that in C and still make it human-readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can think of some ways to do that, but none of them are necessarily easy, nor elegant.
We can revisit this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep things connected: #84.