Always use the default workspace directory when building commands context #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text When pre_workflow_hooks is being used to generate atlantis.yaml and projects are set with specific workspaces different than "default", a different directory is created for each project-workspace pair, but all those that are not on the "default" workspace will not have an atlantis.yaml file at their root. This change ensures that when atlantis is building the projects commands for either: - a project-specific plan, triggered via (atlantis plan -d foo -w bar) - a project-specific apply, triggered vi (atlantis apply -d foo -w bar) - or applies for all the plans it can find (atlantis apply) it uses the default workspace to find the atlantis.yaml config.
giuli007
requested review from
vikramjakhr,
vulpine,
bobtfish,
filipposc5,
giuliano108,
janpokrzywinski and
technicaljones
giuliano108
approved these changes
Jun 7, 2021
technicaljones
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as runatlantis#1620 (opened on the upstream project) but it is based on Yelp/atlantis
masterbranch which is currently fixed atv0.17.0.This way we can merge it and release it internally without pulling in all the unreleased changes that exist on the upstream
masterbranch.See the upstream PR for details. TLDR it fixes errors when using
pre_workflow_hooks& non-defaultworkspaces.We need this fix if we want to re-enable parallelism now that we moved the generation of atlantis.yaml on the server-side.
NB this particuar PR does not fix the issues we had with parallelism (PEAUTO-1803) but without it we cannot currently re-enable parallelism unless we go back to store
atlantis.yamlinto the repository (reverting https://github.yelpcorp.com/misc/terraform-code/pull/2559)