Don't remove extraneous configurations, only warn about their presence #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaensch
suggested changes
Nov 5, 2017
bravado_core/spec.py
Outdated
| @@ -244,17 +243,15 @@ def _internal_spec_dict(self): | |||
| else: | |||
| return self.spec_dict | |||
|
|
|||
| def deref(self, ref_dict): | |||
| def _deref(self, ref_dict): | |||
There was a problem hiding this comment.
Hm, should we call this differently? E.g. _force_deref?
tests/spec/validate_config_test.py
Outdated
| ): | ||
| spec = Spec.from_dict(minimal_swagger_dict, origin_url=get_url(minimal_swagger_abspath), config=config) | ||
| assert spec.config != dict(CONFIG_DEFAULTS, **config) | ||
| assert bool(spec.config != dict(CONFIG_DEFAULTS, **config)) is expected_different_config |
There was a problem hiding this comment.
This needs the brackets, but not the bool cast (the brackets are needed due to Python's comparison operator chaining).
macisamuele
force-pushed
the
maci-fix-217
branch
from
3e7b348
to
93c2a7a
Compare
sjaensch
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217 .
The goal of this PR is to fix the current
Yelp/bravadobuild failure.bravadois failing because it used to injectalso_return_responseconfiguration intobravado-coreconfigs, which is not using that config.Since
bravado-coreis not using this config, I'm not adding it intoCONFIG_DEFAULTS, but removing the logic that strips out extraneous configurations.This PR exposes also
_derefmethod in order to force dereferencing of objects even ifinternaly_dereference_refin order to reducetest_deref_flattened_spec_not_recursive_specsflakyness.