Remove instance type check while marshaling models #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k if the model type is correct)
sjaensch
approved these changes
Jan 16, 2018
macisamuele
deleted the
maci-remove-instance-type-check-while-marshaling-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #222
The goal of this PR is to remove model type check while marshaling models.
The "old" behavior adds a sort of type validation even if
validate_responseis set to false.With this PR the only check that is made is that
marshal_modelis abravado_core.model.Modelinstance, so we have guarantees thatmodel_value._as_dict()will not raise an error.