Collect models will not create models for not models objects #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaensch
suggested changes
Feb 9, 2018
tests/model/collect_models_test.py
Outdated
|
|
||
|
|
||
| def test_not_model(minimal_swagger_dict, pet_model_spec): | ||
| minimal_swagger_dict['definitions']['Pet'] = pet_model_spec |
There was a problem hiding this comment.
Maybe add a docstring explaining why we this is not a model, although it has the x-model marker?
There was a problem hiding this comment.
Added docstring and updated documentation
macisamuele
force-pushed
the
maci-not-object-models-does-not-generate-models
branch
from
2555516
to
2004e60
Compare
sjaensch
approved these changes
Feb 9, 2018
macisamuele
deleted the
maci-not-object-models-does-not-generate-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current model discovery generates models also for not models object specs.
This PR aims to solve this issue.
Assuming that the following is a snippet of the swagger specs
{ "definitions": { "list": { "type": "array", "items": {"type": "string"}, "x-model": "list" } } ... }Before this PR this generates a
listmodel (assert Swagger.from_url(...).definitions == {'list': mock.ANY})After this PR
assert Swagger.from_url(...).definitions == {}