Don't use Swagger spec path for API URL #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Swagger spec we should not use the path part of the spec URL, but instead just use the host part of the URL (see the existing comment for build_api_serving_url, as well as https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#fixed-fields ). Also update tests to match new behaviour.
|
Not sure why the 'docs' part of the build failed - seems to be unrelated from this PR? |
macisamuele
approved these changes
Sep 18, 2018
There was a problem hiding this comment.
@mulmschneider thanks a lot for your contribution.
About the docs test failure, don't worry about it has already been addressed by #296
|
Hello, I've opened #299 because this change has caused some test failures for us, there's more detail in that thread, any feedback is appreciated, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Swagger spec we should not use the path part of the
spec URL, but instead just use the host part of the URL (see the
existing comment for build_api_serving_url, as well as
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#fixed-fields
).
Also update tests to match new behaviour.
I don't know if bravado users depend on the current behavior - feedback appreciated.