Add AppVeyor support and fix tests on Windows #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to ensure that bravado-core does properly support Windows platform.
The main changes needed are related to path 2 url conversions (check the fancy
pathname2urlandurl2pathnamefunctions).Along with those fixes:
os.pathand not hand-coding the pathsNOTE: Having appveyor not happy with the tests is not a big blocker as the PRs could still be merged, but it will give us informations about potential regressions on the Windows platform
Appveyor tests are available on: https://ci.appveyor.com/project/macisamuele/bravado-core/builds/24347171