Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse required properties from inherited models #358

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Collapse required properties from inherited models #358

merged 1 commit into from
Nov 5, 2019

Conversation

nickgaya
Copy link
Contributor

@nickgaya nickgaya commented Nov 2, 2019

For models with an allOf schema property, required attributes should be inherited from parent schemas.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.011% when pulling dbbb34a on nickgaya:collapse-required-properties into e5152e2 on Yelp:master.

@sjaensch sjaensch merged commit c46ee32 into Yelp:master Nov 5, 2019
@sjaensch
Copy link
Contributor

Included in version 5.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickgaya @coveralls @sjaensch