Ensure that spec is deep copiable #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macisamuele
force-pushed
the
maci-ensure-that-Spec-is-deep-copiable
branch
from
0ab2830
to
4caa156
Compare
sjaensch
suggested changes
Nov 23, 2019
sjaensch
reviewed
Nov 25, 2019
| return False | ||
|
|
||
| if id(self) == id(other): | ||
| return True |
There was a problem hiding this comment.
Wouldn't it make sense to put the id check first?
bravado_core/spec.py
Outdated
| # all the attributes. | ||
| # NOTE: Few attributes have recursive references to Spec or do not define an equality method we're going to blacklist them | ||
| return all( | ||
| getattr(self, attr_name, None) == getattr(other, attr_name, None) |
There was a problem hiding this comment.
This seems wrong to me - it allows the equality check to pass if one instance has the attribute set, while the other hasn't.
There was a problem hiding this comment.
I'm going to update the return statement in the following way:
- going to use a for loop instead of using
allas it can simplify reading - going to use
getattr(self, attr_name) != getattr(other, attr_name)check - going to catch
AttributeErrorexception to ensure that differences in the defined attributes cause equality check to return False
…he defined attributes are different
sjaensch
approved these changes
Nov 26, 2019
This was referenced Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
bravado_core.spec.Specinstance is currently not deep copiable.So running something like
deepcopy(Spec.from_dict(<valid_specs>))results on an unbounded recursion error.The goal of this PR is to address this issue by defining the
__deepcopy__dunder method.