Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyword exclude to baseline #146

Closed
KevinHock opened this issue Mar 21, 2019 · 0 comments
Closed

Add keyword exclude to baseline #146

KevinHock opened this issue Mar 21, 2019 · 0 comments
Assignees
@domanchi

Comments

@KevinHock
Copy link
Collaborator

In #132 a keyword exclude option was added, but we didn't write what it was to the baseline. This is problematic because e.g. detect-secrets scan --update .secrets.baseline will re-scan and never use the keyword exclude.

I realized this before releasing 0.12.1 but thought it was pretty low priority, as it is mostly used to enable us to not have to bump detect-secrets and detect-secrets-server versions to make additions to the FALSE_POSITIVES dictionary in the keyword plugin, and sync it upstream asynchronously.
@KevinHock KevinHock mentioned this issue May 13, 2019
Closed
@domanchi domanchi self-assigned this Oct 3, 2019
domanchi pushed a commit that referenced this issue Oct 3, 2019
dynamic plugin usage
9283d25 
This removes the hard-coded PluginDescriptors, as well as the associated
hard-coded tests that needed to be changed with the addition of a new
plugin.

In doing so, this also addresses #146.
@domanchi domanchi mentioned this issue Oct 3, 2019
Merged
@domanchi domanchi closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domanchi domanchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevinHock @domanchi