Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more delimiters to BasicAuthDetector #126

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

domanchi
Copy link
Contributor

@domanchi domanchi commented Feb 7, 2019

With helpful description.

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢
Looks sane to me

@@ -5,8 +5,13 @@
from .base import RegexBasedDetector


# This list is derived from RFC 3986 Section 2.2.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just posting for posterity/search-ability that an expanded discussion took place in #123

@domanchi
Copy link
Contributor Author

Testing this internally, this improved precision by ~30%.

@domanchi domanchi merged commit f8ef67c into master Feb 12, 2019
@domanchi domanchi deleted the adding-more-delimiters-to-basic-auth branch February 12, 2019 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants