Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved pre-commit hooks #197

Merged
merged 1 commit into from
Jun 18, 2019
Merged

improved pre-commit hooks #197

merged 1 commit into from
Jun 18, 2019

Conversation

domanchi
Copy link
Contributor

Added two pre-commit hooks for better code standardization:

  • check-builtin-literals
  • double-quote-string-fixer

@domanchi domanchi merged commit eadaabe into master Jun 18, 2019
@domanchi domanchi deleted the improved-pre-commit branch June 18, 2019 13:16
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request May 28, 2020
@justineyster
Fix Artifactory regex to no longer match assignment character (Yelp#197
d62e07d 
)

* Fix Artifactory regex to no longer match assignment character

* Fix 'look-behind requires fixed-width pattern'
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request May 28, 2020
@justineyster
Verify Artifactory catches expected secret (Yelp#198)
866cfcf 
* Verify Artifactory catches expected secret

Follow up of [this comment](https://github.ibm.com/Whitewater/whitewater-detect-secrets/pull/197#discussion_r2457154) on Yelp#197.

* Fix cannot index dict.keys object
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Jul 9, 2020
@justineyster
Fix Artifactory regex to no longer match assignment character (Yelp#197
9e30f00 
)

* Fix Artifactory regex to no longer match assignment character

* Fix 'look-behind requires fixed-width pattern'
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Jul 9, 2020
@justineyster
Verify Artifactory catches expected secret (Yelp#198)
6d5d795 
* Verify Artifactory catches expected secret

Follow up of [this comment](https://github.ibm.com/Whitewater/whitewater-detect-secrets/pull/197#discussion_r2457154) on Yelp#197.

* Fix cannot index dict.keys object
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Sep 17, 2020
@justineyster
Verification for Artifactory tokens (Yelp#190)
9313949 
Supports git-defenders/detect-secrets-discuss#173

Fix Artifactory validation failure case (Yelp#195)

Closes git-defenders/detect-secrets-discuss#207

Fix Artifactory regex to no longer match assignment character (Yelp#197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domanchi