Reduce number of file reads in audit and scan runs #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OiCMudkips
force-pushed
the
stop_reading_files_multiple_times_in_scan
branch
from
37c5f0e
to
26755d3
Compare
OiCMudkips
changed the title
added 2 commits
August 1, 2019 15:58
This reduces the flakiness of the code coverage check. In particular, this code was covered in py37 but not previous versions. Also, this just makes it easier to pass the coverage test.
OiCMudkips
force-pushed
the
stop_reading_files_multiple_times_in_scan
branch
from
26755d3
to
9e97624
Compare
OiCMudkips
changed the title
domanchi
approved these changes
Aug 2, 2019
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
Makes improvements and follows conventions which I learned by working on Yelp#213
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
* Function to capture other factors for Box credentials Supports git-defenders/detect-secrets-discuss#205 * Client id regexes * publickeyid regexes * Implemented functionality, just need test cases * First get_other_factors test * get_other_factors tests, get build to pass * Tests for get_box_user * Test verify * UNVERIFIED case * Unnecessary install * Attempt to fix build issue * Don't exit loop unless done iterating or verified_true * More comments addressed * Address more comments * UNVERIFIED * find_other_factor
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
Makes improvements and follows conventions which I learned by working on Yelp#213
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
* Function to capture other factors for Box credentials Supports git-defenders/detect-secrets-discuss#205 * Client id regexes * publickeyid regexes * Implemented functionality, just need test cases * First get_other_factors test * get_other_factors tests, get build to pass * Tests for get_box_user * Test verify * UNVERIFIED case * Unnecessary install * Attempt to fix build issue * Don't exit loop unless done iterating or verified_true * More comments addressed * Address more comments * UNVERIFIED * find_other_factor
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
Supports git-defenders/detect-secrets-discuss#205 Box Verification (Yelp#213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeSnippetHighlighterto accept an already-read fileauditfunctionality cache last-read filemaxsize=1addresses this concern: Improvement: Cache last-opened files #210 (comment)... once we're done with a file, we don't need that info cached anymore.Justification for this is mostly in #210. Fixes #210.