-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update pre-commit hook versions #221
Merged
KevinHock
merged 4 commits into
Yelp:master
from
killuazhu:contribute-update-pre-commit
Aug 14, 2019
Merged
fix: update pre-commit hook versions #221
KevinHock
merged 4 commits into
Yelp:master
from
killuazhu:contribute-update-pre-commit
Aug 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢, thanks Kyle! 🙏
Oh, it seems you need to run the trailing comma pre-commit hook in order to get Travis to pass |
@KevinHock updated, Travis is passing now. |
KevinHock
approved these changes
Aug 14, 2019
Thanks 🙏😊 |
killuazhu
pushed a commit
to killuazhu/detect-secrets
that referenced
this pull request
Oct 28, 2019
* Fix Cloud IAM detector bug * Test the failing syntax apikey:<key> * Make ibm cloud iam keywords optional
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
* Fix Cloud IAM detector bug * Test the failing syntax apikey:<key> * Make ibm cloud iam keywords optional
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
* Fix Cloud IAM detector bug * Test the failing syntax apikey:<key> * Make ibm cloud iam keywords optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pre-commit hook plugin versions.