Contribute cloudant plugin #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
reviewed
Oct 31, 2019
| token=token, | ||
| ) | ||
|
|
||
| response = requests.get( |
There was a problem hiding this comment.
Can you do the specific exception thing here?
Rest of the PR ✅ ⛵️ 🚢 👍
There was a problem hiding this comment.
Comment addressed.
KevinHock
reviewed
Oct 31, 2019
Yes, we use Github Enterprise internally, which might mess up with the PR. I can remove the PR id from commit message to avoid confusion. |
* 1st pass cloudant tests and detector * cleaning debugs * whitelisting secret false positive * correcting lint errors * correct line break errors * more lint * more lint * more lint * more lint * typo * more lint * more lint * PR responses
* clarify var names in test * help text * correcting account / pw test verification path * correcting validation error response * change detector vars & add cases * detection tests clean pending verification tests * all tests clean * added more key assignment tests * PR simplifications * fix capture group * fix capture group 2
* feat: use assign regex in cloudant * feat: use assign regex in db2 * feat: use assign regex in gh * feat: use assign regex in iam * feat: use assign regex in sl * address comments * address comments * address comments
* feat: enhance cloudant * address comment * fix broken buid
killuazhu
force-pushed
the
contribute-cloudant
branch
from
79e4e9c
to
29589cb
Compare
|
Pushed again with updated commit message. |
KevinHock
approved these changes
Oct 31, 2019
killuazhu
force-pushed
the
contribute-cloudant
branch
from
29589cb
to
d2f5317
Compare
|
Retrigger Travis build. |
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 28, 2020
* Fix hung build * Don't install cos
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Jul 9, 2020
* Fix hung build * Don't install cos
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
* Fix hung build * Don't install cos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one more plugin to detect Cloudant tokens.