🐛 Fix missing tuple() conversion #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to link to the issue: This fixes #316. |
That raised a `TypeError` when using `scan --update` Also correct mentions of v0.13.2, which was the wrongly anticipated version, to v0.14.0 Fixes issue Yelp#316
KevinHock
force-pushed
the
fix_316_custom_plugins_bug
branch
from
2f8e030
to
ede144e
Compare
We forgot to run `scripts/bumpity.py` I realized bumpity is unfortunately brittle. It looks for the current version in the README and replaces it. So if we make this mistake once, bumpity doesn't find the `rev:` line.
|
Thanks @OiCMudkips! p.s. If you run |
|
Whoops! I'll be sure to do that in the future. |
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
Sep 17, 2020
jimmyhlee94
pushed a commit
to jimmyhlee94/detect-secrets
that referenced
this pull request
Aug 19, 2021
* One more regex for iam * missing args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correct mentions of v0.13.2, which was the wrongly anticipated version, to v0.14.0.
Note: We have had bugs in the past with --update, a few mentioned in the CHANGELOG and a couple not. We should have a test that would of caught this. I'll think about adding one but for now given the priority that can come in a follow-up PR.