Upstream pull #3188
Closed
Upstream pull #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for must_not in addition to filter
Feat crontrigger
adding new features to readme
fixing start time for cron_schedule rules
…'append_middle' take into account the scenario whereby an event is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3161 - no, ci error
#3141 - no, ci error
#3017 - no, breaks tests
#2881 - bad object
#2858 - yes
#2759 (this one actually happened to me) - yes
#2750 - no, undocumented
#2653 - bad object
jertel/elastalert2#157 - yes
tests are breaking in master anyway so I couldn't test locally if the pr's with CI errors actually break tests.
Would it be a good idea to push changes from this fork to https://github.com/jertel/elastalert2 and let them handle maintenance?