swagger-spec-compatibility is not compatible with bravado-core==5.16.0 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read more about the issue on Yelp/bravado-core#363
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 60 60
Lines 1891 1891
Branches 121 121
=====================================
Hits 1891 1891Continue to review full report at Codecov.
|
sjaensch
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted by @garyhoren, using a fresh install of swagger-spec-compatibility raises
This is caused because the latest bravado-core version (5.16.0) has changed the hashability propery of
bravado_core.spec.Specinstances. More details are available on Yelp/bravado-core#363.In order to limit the bleeding of the issue, I'm updating the requirements of the package by highlighting the incompatibility by blacklisting version
5.16.0ofbravado-core.This PR will fix the tests of the package, that are currently red