Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAllowedDoktypes in frontend context #283

Closed
RinyVT opened this issue Aug 20, 2019 · 1 comment
Closed

getAllowedDoktypes in frontend context #283

RinyVT opened this issue Aug 20, 2019 · 1 comment
Assignees
@haassie
Labels
needs-code-review

Comments

@RinyVT
Copy link
Collaborator

RinyVT commented Aug 20, 2019

  • [*] I've read and understood the contribution guidelines.
  • [*] I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

When clearing the cache and accessing the frontend, the cache will get build with frontend-context.
The function getAllowedDoktypes does not return the additional (user) defined doktypes in frontend-context, which causes the TCA to not get build on these additional doktypes.

Please describe what you expected to happen and why.

getAllowedDoktypes works in frontend context.

How can we reproduce this behavior?

  1. Define an additional doktype within module.tx_yoastseo.settings.allowedDoktypes
  2. Clear all caches
  3. Access the frontend before the backend generates the new caches
  4. See the generated TCA
@haassie haassie self-assigned this Aug 23, 2019
haassie pushed a commit that referenced this issue Aug 23, 2019
[TASK] Set the doktypes that can be analyzed in a way, it is always a…
dd8cb28 
…vailable

By setting the allowed doktypes via `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['yoast_seo']['allowedDoktypes']`
it will always be available. This prevents you miss the Yoast analysis
in the backend when you visited the page in frontend directly before
reloading your page in the backend.

Resolves: #283
@haassie haassie added this to the 5.1.0 milestone Aug 26, 2019
@haassie
Copy link
Contributor

haassie commented Sep 19, 2019

Fixed with 63a1ea8

@haassie haassie closed this as completed Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haassie haassie

Labels
needs-code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RinyVT @haassie