Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] harden broken types #524

Merged
merged 4 commits into from
Jul 5, 2023
Merged

[BUGFIX] harden broken types #524

merged 4 commits into from
Jul 5, 2023

Conversation

kaystrobach
Copy link
Contributor

Avoid exceptions because of broken showItems

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@kaystrobach
[BUGFIX] harden broken types
65604a1 
Avoid exceptions because of broken showItems
@kaystrobach
Copy link
Contributor Author

please backport to v8 and also apply in v9. Thanks a lot.

@RinyVT RinyVT merged commit a54abd6 into Yoast:main Jul 5, 2023
4 checks passed
@RinyVT RinyVT mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaystrobach @RinyVT