Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Removed non-existing / unnecessary CSS file within PageOverviewWidget #538

Merged
merged 2 commits into from
Jul 5, 2023
Merged

[BUGFIX] Removed non-existing / unnecessary CSS file within PageOverviewWidget #538

merged 2 commits into from
Jul 5, 2023

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Jun 29, 2023

Summary

This PR can be summarized in the following changelog entry:

  • Non-existing css file extended-list-widget.min.css from PageOverviewWidget

Relevant technical choices:

  • Removed the whole getCssFiles method and the AdditionalCssInterface

Test instructions

This PR can be tested by following these steps:

  • Pull branch and check if the dashboard widgets are still working

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #537

@RinyVT RinyVT force-pushed the bugfix/537-non-existing-css-file branch from e7e3962 to 0c3f9f0 Compare June 29, 2023 08:57
@RinyVT RinyVT merged commit adafed0 into main Jul 5, 2023
9 checks passed
@RinyVT RinyVT deleted the bugfix/537-non-existing-css-file branch July 5, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PageOverviewWidget load not existing CSS file
1 participant
@RinyVT