Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixed loading state of internal linking suggestions when bodytext is empty (e.g. new content element) #540

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Jun 29, 2023

Summary

This PR can be summarized in the following changelog entry:

  • When the bodytext was empty, the internal linking suggestions would be kept in a loading state because the loading state is triggered with an empty "content" variable. This PR fixes that.

Relevant technical choices:

  • Instead of checking if the content is empty, the getCKEditorContent now returns null if the CKEditor has not yet finished loading. This way, it's still possible to have empty content but the loading state is not dependent on it anymore.

Test instructions

This PR can be tested by following these steps:

  • Pull branch and check if the loading state now disappears when CKeditor is done loading

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #536

@RinyVT RinyVT merged commit c0a87bb into main Jul 5, 2023
9 checks passed
@RinyVT RinyVT deleted the bugfix/536-loading-state-internal-linking-suggestions branch July 5, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless loading animation for empty bodytext within the field internal linking suggestions
1 participant