Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented filter type wrong #21695

Closed
kkmuffme opened this issue Oct 10, 2024 · 1 comment · Fixed by #21739
Closed

Documented filter type wrong #21695

kkmuffme opened this issue Oct 10, 2024 · 1 comment · Fixed by #21739

Comments

@kkmuffme
Copy link
Contributor

When running some static analysis tests we encountered a type documentation issue in:
https://github.com/Yoast/wordpress-seo/blob/trunk/inc/options/class-wpseo-option-wpseo.php#L217
https://github.com/Yoast/wordpress-seo/blob/trunk/admin/tracking/class-tracking.php#L223

should be @param string|false instead of @param string

@josevarghese
Copy link
Contributor

Hi @kkmuffme

Thanks for creating the issue and sharing the details. You can contribute to our plugin easily by sending a PR - see more info here: https://github.com/Yoast/wordpress-seo/blob/trunk/.github/CONTRIBUTING.md

kkmuffme added a commit to kkmuffme/wordpress-seo that referenced this issue Oct 22, 2024
kkmuffme added a commit to kkmuffme/wordpress-seo that referenced this issue Oct 22, 2024
@kkmuffme kkmuffme mentioned this issue Oct 22, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants