Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Server): support custom connectors #781

Merged
merged 1 commit into from
May 25, 2020
Merged

Conversation

chentsulin
Copy link
Collaborator

  • Support custom connectors in bottender.config.js.
  • Add some tests for Server.ts.

@chentsulin chentsulin requested review from etrex and wtflink May 25, 2020 06:46
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #781 into release/1.5 will increase coverage by 0.93%.
The diff coverage is 85.71%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.5     #781      +/-   ##
===============================================
+ Coverage        81.08%   82.01%   +0.93%     
===============================================
  Files              108      108              
  Lines             4747     4754       +7     
  Branches          1197     1153      -44     
===============================================
+ Hits              3849     3899      +50     
+ Misses             862      825      -37     
+ Partials            36       30       -6     
Impacted Files Coverage Δ
packages/bottender/src/types.ts 100.00% <ø> (ø)
packages/bottender/src/server/Server.ts 63.44% <85.71%> (+52.97%) ⬆️
packages/bottender/src/chain.ts 76.92% <0.00%> (ø)
packages/bottender/src/getClient.ts 55.55% <0.00%> (ø)
packages/bottender/src/router/index.ts 90.66% <0.00%> (ø)
packages/create-bottender-app/src/shared/log.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5ab7f0...151715b. Read the comment docs.

@chentsulin chentsulin requested a review from tw0517tw May 25, 2020 07:23
@chentsulin chentsulin merged commit bab0cad into release/1.5 May 25, 2020
@chentsulin chentsulin deleted the custom-connector branch May 25, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants