Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: re-export types #804

Merged
merged 1 commit into from
Jun 17, 2020
Merged

type: re-export types #804

merged 1 commit into from
Jun 17, 2020

Conversation

chentsulin
Copy link
Collaborator

@chentsulin chentsulin commented Jun 16, 2020

Merge types from messaging-api and bottender and re-export them again.

@chentsulin chentsulin force-pushed the re-export-types branch 6 times, most recently from 8797fc0 to 7ee49fc Compare June 17, 2020 03:20
@chentsulin chentsulin marked this pull request as ready for review June 17, 2020 03:21
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #804 into release/1.5 will increase coverage by 0.22%.
The diff coverage is 99.65%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.5     #804      +/-   ##
===============================================
+ Coverage        83.65%   83.88%   +0.22%     
===============================================
  Files              115      120       +5     
  Lines             6068     6154      +86     
  Branches          1491     1520      +29     
===============================================
+ Hits              5076     5162      +86     
  Misses             988      988              
  Partials             4        4              
Impacted Files Coverage Δ
packages/bottender/src/messenger/MessengerBot.ts 100.00% <ø> (ø)
packages/bottender/src/slack/SlackEvent.ts 93.84% <ø> (ø)
packages/bottender/src/slack/routes.ts 100.00% <ø> (ø)
packages/bottender/src/telegram/TelegramContext.ts 58.78% <ø> (ø)
packages/bottender/src/telegram/TelegramEvent.ts 97.50% <ø> (ø)
packages/bottender/src/viber/ViberEvent.ts 100.00% <ø> (ø)
packages/bottender/src/whatsapp/WhatsappBot.ts 100.00% <ø> (ø)
...ckages/bottender/src/whatsapp/WhatsappConnector.ts 93.02% <ø> (ø)
packages/bottender/src/messenger/MessengerEvent.ts 99.29% <99.37%> (+0.19%) ⬆️
...ckages/bottender-facebook/src/FacebookConnector.ts 66.00% <100.00%> (+0.69%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a89283...bf1221c. Read the comment docs.

@chentsulin chentsulin force-pushed the re-export-types branch 2 times, most recently from ba09dfa to 6aacfee Compare June 17, 2020 04:19
@chentsulin chentsulin merged commit 4b9a38c into release/1.5 Jun 17, 2020
@chentsulin chentsulin deleted the re-export-types branch June 17, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants