Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export clients, factories from messaging-apis #806

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

chentsulin
Copy link
Collaborator

So we can easily use the same version clients in our bots and message push system.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #806 into release/1.5 will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.5     #806      +/-   ##
===============================================
+ Coverage        83.88%   83.90%   +0.02%     
===============================================
  Files              120      120              
  Lines             6154     6162       +8     
  Branches          1520     1520              
===============================================
+ Hits              5162     5170       +8     
  Misses             988      988              
  Partials             4        4              
Impacted Files Coverage Δ
packages/bottender/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3589b08...af37139. Read the comment docs.

@chentsulin chentsulin merged commit f050276 into release/1.5 Jun 17, 2020
@chentsulin chentsulin deleted the export-client branch June 17, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants