Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type(bottender-facebook): add type details for feed events #808

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

wtflink
Copy link
Member

@wtflink wtflink commented Jun 17, 2020

After go though around 2000~4000 events, I sort out the types and they should be like this but not totally sure about them.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #808 into release/1.5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.5     #808   +/-   ##
============================================
  Coverage        83.93%   83.93%           
============================================
  Files              120      120           
  Lines             6167     6167           
  Branches          1523     1523           
============================================
  Hits              5176     5176           
  Misses             987      987           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611534b...c9b7ce4. Read the comment docs.

@wtflink wtflink requested a review from chentsulin June 17, 2020 08:13
createdTime: number;
photoId: string;
published: 0 | 1;
verb: 'add' | 'edit';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited

postId: string;
createdTime: number;
published: 0 | 1;
verb: 'add' | 'edit';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited

postId: string;
createdTime: number;
published: 0 | 1;
verb: 'add' | 'edit';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited

verb: 'mute';
videoId: string;
}
| {
Copy link
Collaborator

@chentsulin chentsulin Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
"video_flag_reason" : 1,
"item" : "video",
"verb" : "block",
"video_id" : "6388823369xxxxx"
}

message?: string;

Copy link
Collaborator

@chentsulin chentsulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chentsulin chentsulin merged commit 8eaf0f6 into release/1.5 Jun 17, 2020
@chentsulin chentsulin deleted the add-types-details branch June 17, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants