Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New v63003/gtm8854 subtest (tests GTM-8854 in V63003) #218

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

VinayYottaDB
Copy link
Contributor

Tests the following release note:

The compiler appropriately handles a syntax error in the argument of a postconditional command when the postconditional is a literal that evaluates to FALSE. Due to a regression associated with GTM-8573 in rm inV6.3-001[A], this combination caused an abnormal termination with a segmentation violation (SIG-11). (GTM-8854)

@VinayYottaDB VinayYottaDB requested a review from nars1 June 8, 2018 20:22
@VinayYottaDB VinayYottaDB self-assigned this Jun 8, 2018
;

gtm8854
write:0 "bad syntax
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like two tests to be additionally done. They need to be done in separate labels and invoked from the .csh script separately as each of them is going to error out.

hang:0
hang:0 0,

@@ -31,14 +31,15 @@
# gtm8780 [vinay] Tests $SELECT() produces a syntax error for an omitted colon after a literal true argument
# gtm8787 [vinay] Tests Mupip Journal -Extract=-stdout properly handles its termination
# gtm8889 [vinay] Tests zhelp does not produce an error when <Ctrl C> is pressed
# gtm8854 [vinay] Tests syntax error in the argument of a FALSE postconidtional is handled appropriately
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo : postconditional

@VinayYottaDB VinayYottaDB merged commit bdb9d8a into YottaDB:master Jun 11, 2018
@VinayYottaDB VinayYottaDB deleted the gtm8854 branch June 11, 2018 14:26
JakeYottaDB pushed a commit to JakeYottaDB/YottaDBtest that referenced this pull request Jun 29, 2018
…/YDB#218)

Two test framework scripts that were already VIEW "NOISOLATION" were identified.

1) imptp.m
2) tpntpupd.m

And they were enhanced to check for the new env var and if present use that
and if not do VIEW "NOISOLATION" commands like they previously did.

This way all tests that use imptp.m (many dozens) and tpntpupd.m (2 tests) will
automatically test the new env var.

Took this opportunity to do some "usesimpleapi"-related cleanup in imptp.csh.
JakeYottaDB pushed a commit to JakeYottaDB/YottaDBtest that referenced this pull request Jun 29, 2018
…n env var might be set (if called through dbcheck.csh from v53002/C9E04002596 subtest) and can cause ZGBLDIRACC errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants