refactor(services/dropbox): Use OpWrite instead of passing all args a…

…s parameters (apache#3126)
Young-Flash · Sep 19, 2023 · 62c1361 · 62c1361
1 parent b56c310
commit 62c1361
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/core/src/services/dropbox/core.rs b/core/src/services/dropbox/core.rs
@@ -98,11 +98,11 @@ impl DropboxCore {
         &self,
         path: &str,
         size: Option<usize>,
-        content_type: Option<&str>,
+        args: &OpWrite,
         body: AsyncBody,
     ) -> Result<Response<IncomingAsyncBody>> {
         let url = "https://content.dropboxapi.com/2/files/upload".to_string();
-        let args = DropboxUploadArgs {
+        let dropbox_update_args = DropboxUploadArgs {
             path: build_rooted_abs_path(&self.root, path),
             ..Default::default()
         };
@@ -112,13 +112,13 @@ impl DropboxCore {
         }
         request_builder = request_builder.header(
             CONTENT_TYPE,
-            content_type.unwrap_or("application/octet-stream"),
+            args.content_type().unwrap_or("application/octet-stream"),
         );
 
         let mut request = request_builder
             .header(
                 "Dropbox-API-Arg",
-                serde_json::to_string(&args).map_err(new_json_serialize_error)?,
+                serde_json::to_string(&dropbox_update_args).map_err(new_json_serialize_error)?,
             )
             .body(body)
             .map_err(new_request_build_error)?;

diff --git a/core/src/services/dropbox/writer.rs b/core/src/services/dropbox/writer.rs
@@ -47,7 +47,7 @@ impl oio::OneShotWrite for DropboxWriter {
             .dropbox_update(
                 &self.path,
                 Some(bs.len()),
-                self.op.content_type(),
+                &self.op,
                 AsyncBody::ChunkedBytes(bs),
             )
             .await?;