Skip to content

Commit

Permalink
Remove "Upgrade" badge on disabled action types in the create connect…
Browse files Browse the repository at this point in the history
…or flyout
  • Loading branch information
YulNaumenko committed Mar 24, 2020
1 parent b82cc6e commit 6c9926c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,6 @@ describe('connector_add_flyout', () => {
</ActionsConnectorsContextProvider>
);

const element = wrapper.find('[data-test-subj="my-action-type-card"]');
expect(element.exists()).toBeTruthy();
expect(element.first().prop('betaBadgeLabel')).toEqual('Upgrade');
expect(element.first().prop('betaBadgeTooltipContent')).toEqual(
'This connector is disabled because it requires a gold license.'
);
expect(wrapper.find('EuiToolTip [data-test-subj="my-action-type-card"]').exists()).toBeTruthy();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import React, { useEffect, useState } from 'react';
import { EuiFlexItem, EuiCard, EuiIcon, EuiFlexGrid, EuiSpacer } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { EuiToolTip } from '@elastic/eui';
import { ActionType, ActionTypeIndex } from '../../../types';
import { loadActionTypes } from '../../lib/action_connector_api';
import { useActionsConnectorsContext } from '../../context/actions_connectors_context';
Expand Down Expand Up @@ -81,21 +82,19 @@ export const ActionTypeMenu = ({
description={item.selectMessage}
isDisabled={!checkEnabledResult.isEnabled}
onClick={() => onActionTypeChange(item.actionType)}
betaBadgeLabel={
checkEnabledResult.isEnabled
? undefined
: i18n.translate(
'xpack.triggersActionsUI.sections.actionsConnectorsList.upgradeBadge',
{ defaultMessage: 'Upgrade' }
)
}
betaBadgeTooltipContent={
checkEnabledResult.isEnabled ? undefined : checkEnabledResult.message
}
/>
);

return <EuiFlexItem key={index}>{card}</EuiFlexItem>;
return (
<EuiFlexItem key={index}>
{checkEnabledResult.isEnabled && card}
{checkEnabledResult.isEnabled === false && (
<EuiToolTip position="top" content={checkEnabledResult.message}>
{card}
</EuiToolTip>
)}
</EuiFlexItem>
);
});

return (
Expand Down

0 comments on commit 6c9926c

Please sign in to comment.