well-known support #136
Merged
well-known support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update my fork
Choose server name
Add server_name="domain2.tld" (DOMAIN)
DNS conf become optionnal with .well-known edition
Create .well-known redirection for access by federation
If not existing, create .well-known redirection for access by federation
back to 0.99.5.2
for access by federation and applications like Riot.im
for access by federation and applications like Riot.im
Thatoo
changed the title
|
@YunoHost-Apps/apps-group Can somebody who as the access to the CI relaunch the test ? |
kay0u
reviewed
Nov 24, 2019
|
CI relaunched 😉 |
|
@JimboJoe can you relaunch now? |
|
It relaunched automatically by itself (as it almost always does) 😉 |
Josue-T
reviewed
Nov 25, 2019
Josue-T
reviewed
Nov 25, 2019
Josue-T
reviewed
Nov 25, 2019
Josue-T
reviewed
Nov 25, 2019
Josue-T
requested changes
Nov 25, 2019
Co-Authored-By: Josue-T <[email protected]>
Co-Authored-By: Josue-T <[email protected]>
Co-Authored-By: Josue-T <[email protected]>
Co-Authored-By: Josue-T <[email protected]>
Thatoo
commented
Nov 25, 2019
Josue-T
approved these changes
Nov 26, 2019
|
I purpose to squash all of these commit when we merge this because it's just much 90 commit for this... |
|
Ready for a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Getting the option to choose a server_name at installation without further work from the user who install this package
#92
Solution
Add a server_name variable during install
Add a .well-known delegation with a nginx redirection (location). I got help from tulir from the synapse room. If you would like to see picture of it working, I took ssome screenshot.
Installation is ok and federation is working but I didn't try yet backup, upgrade and restore. I'll do that when the current testing PR will be merged into master.
PR Status
Validation
Minor decision
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.