Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #215

Merged
merged 13 commits into from
Sep 9, 2024
Merged

Testing #215

merged 13 commits into from
Sep 9, 2024

Conversation

ericgaspar
Copy link
Member

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

kay0u and others added 11 commits July 20, 2024 10:59
* Auto-update READMEs

* fix hook

---------

Co-authored-by: yunohost-bot <[email protected]>
* Add parameters.yml

* Update upgrade

* Update change_url
* Add parameters.yml

* Update upgrade

* add function
* Testing (#207)

* Fix hook (#206)

* Auto-update READMEs

* fix hook

---------

Co-authored-by: yunohost-bot <[email protected]>

* Update manifest.toml (#208)

* Update manifest.toml

* Auto-update READMEs

* Add parameters.yml (#209)

* Add parameters.yml

* Update upgrade

* Update change_url

* Function (#210)

* Add parameters.yml

* Update upgrade

* add function

---------

Co-authored-by: Kayou <[email protected]>
Co-authored-by: yunohost-bot <[email protected]>

* Auto-update READMEs

* [autopatch] Automatic patch attempt for helpers 2.1

* cleaning

---------

Co-authored-by: eric_G <[email protected]>
Co-authored-by: Kayou <[email protected]>
Co-authored-by: Yunohost-Bot <>
@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

🪱
Test Badge

@yunohost-bot
Copy link
Contributor

🎠
Test Badge

@lapineige lapineige merged commit b9769d3 into master Sep 9, 2024
@YunoHost-Apps YunoHost-Apps deleted a comment from yunohost-bot Sep 9, 2024
@YunoHost-Apps YunoHost-Apps deleted a comment from yunohost-bot Sep 9, 2024

# Download, check integrity, uncompress and patch the source from app.src
ynh_setup_source --dest_dir="$install_dir"

# Create log dir/file FIXME: is it useless?
# Create log dir/file is it useless?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing the fixme and not the comment ? It is fixed ?

Copy link
Member

@lapineige lapineige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the .patch files removed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants