Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace wp fail2ban #78

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Replace wp fail2ban #78

merged 2 commits into from
Jan 2, 2020

Conversation

maniackcrudelis
Copy link

@maniackcrudelis maniackcrudelis commented Dec 28, 2019 •
edited by kay0u
Loading

Problem

  • wp-fail2ban plugin is becoming a premium plugin with a recurrent ads about going to the premium version.
  • And the main dev of this plugin seems to not care about it.

Solution

  • Remove wp-fail2ban and replace it by wp-fail2ban-redux.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team December 28, 2019 11:14
@maniackcrudelis maniackcrudelis changed the base branch from master to testing December 28, 2019 11:18
JimboJoe
JimboJoe approved these changes Dec 29, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JimboJoe JimboJoe requested a review from a team December 29, 2019 10:30
kay0u
kay0u approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & code review

@kay0u
Copy link
Member

kay0u commented Dec 30, 2019

Can be merged in 3 days

@maniackcrudelis maniackcrudelis merged commit e7194ed into testing Jan 2, 2020
@maniackcrudelis maniackcrudelis deleted the replace_wp-fail2ban branch January 2, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@JimboJoe JimboJoe JimboJoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maniackcrudelis @kay0u @JimboJoe