Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog #82

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Add changelog #82

merged 2 commits into from
Jan 31, 2020

Conversation

maniackcrudelis
Copy link

@maniackcrudelis maniackcrudelis commented Jan 4, 2020 •
edited by JimboJoe
Loading

Problem

  • No changelog

Solution

  • Add a changelog

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team January 4, 2020 17:54
kay0u
kay0u approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & code review

@maniackcrudelis
Copy link
Author

up

JimboJoe
JimboJoe approved these changes Jan 28, 2020
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JimboJoe
Copy link

Can be merged in 3 days.

@maniackcrudelis maniackcrudelis merged commit 8ecea3d into testing Jan 31, 2020
@maniackcrudelis maniackcrudelis deleted the add_changelog branch January 31, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@JimboJoe JimboJoe JimboJoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maniackcrudelis @JimboJoe @kay0u