Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show YunoHost tile #91

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Always show YunoHost tile #91

merged 1 commit into from
Apr 1, 2020

Conversation

maniackcrudelis
Copy link

@maniackcrudelis maniackcrudelis commented Mar 19, 2020 •
edited by JimboJoe
Loading

Problem

  • TheYunoHost tile isn't shown since an upgrade of the private/public code

Solution

  • Always show the tile.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team March 19, 2020 11:13
JimboJoe
JimboJoe approved these changes Mar 29, 2020
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JimboJoe
Copy link

Can be merged in 3 days.

@maniackcrudelis maniackcrudelis merged commit 7f94617 into testing Apr 1, 2020
@maniackcrudelis maniackcrudelis deleted the ynh_tile branch April 1, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@JimboJoe JimboJoe JimboJoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maniackcrudelis @JimboJoe @kay0u