Replace deprecated gmstrftime PHP function #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmstrftime - Warning: This function has been DEPRECATED as of PHP 8.1.0. Relying on this function is highly discouraged. Adding a new static function to Utils.php to generate the the required Compact Date strings to send to the device.
PHP 8.0 stopped allowing empty strings to be passed to gmstrftime. This led to the previously suggested change to replace the empty string with null. Unfortunately, that change collided with the gmstrftime also accepting null as a valid input where it would return the current time formatted as requested. This led to contacts who had empty Anniversary and Birthday fields getting their empty strings replaced by nulls, and subsequently getting passed to gmstrftime which would assign them values of the current time. The correct behaviour for the streamer in this instance is to just return the empty string
|
Thanks for the PR, will test this for a few days and then merge. |
|
You can see the before/after in this - https://3v4l.org/eUbA1 - it doesn't
matter what your date_default_timezone is set to, as the ActiveSync
timestamps are always UTC by the time they get to the streamer
…On Wed, 31 May 2023 at 06:51, matidau ***@***.***> wrote:
Thanks for the PR, will test this for a few days and then merge.
—
Reply to this email directly, view it on GitHub
<#12 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVBYIQ7FIPRJANI3QSCK3DXI3L7ZANCNFSM6AAAAAAYT3KNIE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gmstrftime - Warning: This function has been DEPRECATED as of PHP 8.1.0. Relying on this function is highly discouraged.
Adding a new static function to Utils.php to generate the the required Compact Date strings to send to the device.
Released under the GNU Affero General Public License (AGPL), version 3
What does this implement/fix? Explain your changes.
Adds a new function to Utils.php
and replaces calls to the deprecated gmstrftime with calls to this new function
...
Does this close any currently open issues?
No.
...
Any relevant logs, error output, etc?
...
Where has this been tested?
Server (please complete the following information):
Smartphone (please complete the following information):