Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some PHP8 errors for IMAP backend #31

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

DoobleD
Copy link
Contributor

@DoobleD DoobleD commented Oct 19, 2023

Released under the GNU Affero General Public License (AGPL), version 3 and Trademark Additional Terms.

What does this implement/fix? Explain your changes.

Fixes some errors with PHP 8.x for the IMAP backend. In particular this change line 1131 fixes these 2 fatal errors:

[FATAL] [<user>] Fatal error: /<path>/z-push/backend/imap/imap.php:1132 - Uncaught TypeError: implode(): Argument #2 ($array) must be of type ?array, bool given in /<path>/z-push/backend/imap/imap.php:1132

and

[FATAL] [<user>] Fatal error: /<path>/z-push/backend/imap/imap.php:1177 - Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, bool given in /<path>/z-push/backend/imap/imap.php:1177

Does this close any currently open issues?

Not that I know of.

Any relevant logs, error output, etc?

See above.

Where has this been tested?

Server (please complete the following information):

  • OS: Debian 11
  • PHP Version: 8.2
  • Backend for: IMAP
  • and Version: 7.1

Smartphone (please complete the following information):

  • Device: Android
  • OS: Android 13
  • Mail App: Outlook
  • Version: 4.2338.0

@matidau
Copy link
Collaborator

matidau commented Oct 25, 2023

Thanks for this PR.

Will test and merge.

@matidau matidau merged commit 144ecb7 into Z-Hub:develop Oct 27, 2023
2 checks passed
@dborg89
Copy link

dborg89 commented Jan 11, 2024

Indeed this works!
Apologies for not noticing it in the commit history (just downloaded the latest stable from the releases section when I last updated).

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants