Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix czishrink build by completely disabling roll-forward in global.json #77

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

m-ringler
Copy link
Contributor

@m-ringler m-ringler commented Nov 12, 2024

Description

Fixes broken build

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

PR build.

Checklist

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (953017f) to head (f6871c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   78.03%   78.03%           
=======================================
  Files          59       59           
  Lines        1917     1917           
  Branches      120      120           
=======================================
  Hits         1496     1496           
  Misses        397      397           
  Partials       24       24           
Components Coverage Δ
czicompress 66.75% <ø> (ø)
czishrink 80.84% <ø> (ø)

@m-ringler m-ringler force-pushed the feature/print-dotnet-sdk-version branch 2 times, most recently from 6c3bff0 to 08783c2 Compare November 12, 2024 10:16
@m-ringler m-ringler changed the title Print dotnet version Fix czishrink build by completely disabling roll-forward in global.json Nov 12, 2024
@m-ringler m-ringler added bug Something isn't working cla Contributor License Agreement sent to Admin CI/CD czishrink The issue or PR affects czishrink .NET Pull requests that update .net code labels Nov 12, 2024
@m-ringler m-ringler force-pushed the feature/print-dotnet-sdk-version branch from 08783c2 to f6871c2 Compare November 12, 2024 10:21
@m-ringler m-ringler marked this pull request as ready for review November 12, 2024 10:37
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does roll-forward break the build here? Is it related to our package locks when updating w/ dependabot?

@m-ringler m-ringler requested a review from a team November 12, 2024 10:46
@m-ringler m-ringler self-assigned this Nov 12, 2024
@m-ringler m-ringler merged commit 922cf00 into main Nov 12, 2024
19 checks passed
@m-ringler m-ringler deleted the feature/print-dotnet-sdk-version branch November 12, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD cla Contributor License Agreement sent to Admin czishrink The issue or PR affects czishrink .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants