Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WCAG error: Empty table header in case of JSX element #378

Merged
merged 1 commit into from
May 24, 2022

Conversation

klaidigorishti
Copy link
Contributor

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

According to WCAG 2 validator, there is "Empty Table Header" error when adding a JSX element on the header.

What does the "Empty Table Header" error mean?

An empty table header error means that one of the table headers on your post or page does not contain any text. This means that the element is present but looks like this with nothing between the opening and closing tags.

The following PR: #372, fixed the case where no text or an empty text was displayed. However, the issue persists when a JSX element is part of the table header.

@klaidigorishti klaidigorishti self-assigned this May 23, 2022
@klaidigorishti klaidigorishti added the bug Something isn't working label May 23, 2022
@klaidigorishti klaidigorishti linked an issue May 23, 2022 that may be closed by this pull request
5 tasks
@dremartins dremartins merged commit ce0979d into main May 24, 2022
@klaidigorishti klaidigorishti deleted the bugfix/377-empty-table-header branch May 24, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCAG: Table has wrong header
2 participants