Tests for binascii #18
Conversation
|
Cross-reference: HypothesisWorks/hypothesis#2430 |
|
Hey @Zac-HD! I have made changes, based on the comments. |
import binascii
binascii.crc_hqx(b"", 2 ** 63)fails (only) on PyPy, with @cfbolz might be able to help us diagnose this? |
|
@Zac-HD nice catch! yes, will look into it! |
|
yep, fixed (an unsigned vs signed int issue, also a change from py2->py3). here's the commit: https://foss.heptapod.net/pypy/pypy/commit/7b826e1a27677daa643bfa4535daafecc4526335 |
|
@cfbolz, impressively fast! We do have https://github.com/Zac-HD/stdlib-property-tests#trophy-case - is there a canonical link to point to for this, or should the new entry just point to this thread and commit link? |
akash-suresh
force-pushed
the
hypothesis-tests-for-binascii
branch
from
0a15ee8
to
966559d
Compare
|
@Zac-HD I'd just point to the commit link - we don't track all changes as issues or anything like that. |
I have added tests for the
binasciimodule. Let me know if there are any corrections needed.