Additional options native embeddings #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2023 17:44
ZachNagengast
requested changes
Nov 2, 2023
There was a problem hiding this comment.
Hey @BernhardEisvogel, great idea! I just made couple suggestions for edits, otherwise looks great!
Sources/SimilaritySearchKit/Core/Embeddings/Models/NativeEmbeddings.swift
Outdated
Show resolved
Hide resolved
Sources/SimilaritySearchKit/Core/Embeddings/Models/NativeEmbeddings.swift
Outdated
Show resolved
Hide resolved
Sources/SimilaritySearchKit/Core/Embeddings/Models/NativeEmbeddings.swift
Show resolved
Hide resolved
…dings.swift Co-authored-by: Zach Nagengast <[email protected]>
…dings.swift Co-authored-by: Zach Nagengast <[email protected]>
|
Great! I will upload another commit later improving the performance of the search algorithm, currently it's ordering the complete list and then it takes "the best" k entries( in O(nlogn) ) but it's sufficient to use some topK algorithm ( in O(n) ) I will open another pull request for that to keep everything ordered. |
ZachNagengast
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone!
I want to use this repository in a language program that need the word embedding instead of the sentence embedding, so I changed a way to switch between those two modes in NativeEmbeddings.init.
Greetings Bernhard
P.s. I'm new to Github