Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to ignore Keywords in doctrings #64

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

srishtiganguly
Copy link

Reference Issue: #62 Keywords in docstring are not ignored

Changes added: Added few lines of code in the is_comment() and is_one_line_method() from utils.py & _get_name() from methods.py to handle content within docstrings to be considered as comments/docstrisngs.

@srishtiganguly srishtiganguly changed the title #62 Added functionality to ignore Keywords in doctrings Added functionality to ignore Keywords in doctrings Feb 28, 2021
@Zarad1993
Copy link
Owner

Hello @srishtiganguly - Thank you so much for your contribution.
Feel free to ping me when this is ready to be reviewed.

Thanks again!

…anges made in 'def is_one_line_method' and 'def sanitize'
@srishtiganguly
Copy link
Author

Hello @srishtiganguly - Thank you so much for your contribution.
Feel free to ping me when this is ready to be reviewed.

Thanks again!

Hello @Zarad1993 , I have made the possible changes to the code and the code is ready for review.
How do I check what check is failing in Travis CI?

@Zarad1993
Copy link
Owner

Hey @srishtiganguly - Sorry took a bit for me to look back. I think it is failing due to tox supporting 2.7 and 3.6 🤔

@Zarad1993
Copy link
Owner

This is the error
It's failing on 3.6 due to click dependency

Screen Shot 2021-03-14 at 11 05 28 PM

@srishtiganguly
Copy link
Author

This is the error
It's failing on 3.6 due to click dependency

Screen Shot 2021-03-14 at 11 05 28 PM

Thank you. Do I have to reinstall click == 7.0 and push the changes? Or would it work when you check on your system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants