Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): do not require a cached state for disk regeneration #8910

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Oct 4, 2024

Motivation

Some tests, but mainly the one that create a cached state from scratch (or regenerate one), do not required an existing disk image to exists in GCP.

This also makes our weekly scheduled full sync to fail: https://github.com/ZcashFoundation/zebra/actions/runs/11179660535

Solution

  • Skip the job that search for the cached disk images, as this one fails if no disk is found

Tests

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles I-integration-fail Continuous integration fails, including build and test failures I-build-fail Zebra fails to build P-Critical 🚑 labels Oct 4, 2024
@gustavovalverde gustavovalverde self-assigned this Oct 4, 2024
@gustavovalverde gustavovalverde changed the title fix(actions): disk regeneration does not required a cached state fix(actions): disk regeneration does not require a cached state Oct 4, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 4, 2024
@gustavovalverde gustavovalverde changed the title fix(actions): disk regeneration does not require a cached state fix(actions): do not require a cached state for disk regeneration Oct 4, 2024
@gustavovalverde gustavovalverde marked this pull request as ready for review October 4, 2024 13:41
@gustavovalverde gustavovalverde requested a review from a team as a code owner October 4, 2024 13:41
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team October 4, 2024 13:41
@mergify mergify bot merged commit 3bf4bc8 into main Oct 4, 2024
158 of 159 checks passed
@mergify mergify bot deleted the fix-ci-rebuild branch October 4, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-build-fail Zebra fails to build I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants