Fix line filter on for clang compiler on windows #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line filters seem to be sensitive to the compiler used. When using MSVC, the line filter must use backslashes in the name. However, if the clang compiler is used on Windows, it must be forward. The simplest solution to this issue is to use an extra entry of the line filter one with forward slashes and one without. This allows all compilers to be happy regardless of OS and without looking at compilation databases.
ZedThree
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line filters seem to be sensitive to the compiler used. When using MSVC, the line filter must use backslashes in the name. However, if the clang compiler is used on Windows, it must be forward.
The simplest solution to this issue is to use an extra entry of the line filter one with forward slashes and one without.
This allows all compilers to be happy regardless of OS and without looking at compilation databases.