-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to edit LGTM message and to turn it off #48
Conversation
Thanks @bwrsandman! I take it setting it to the empty string means the comment doesn't get posted -- does it need an explicit check, or does GitHub automatically reject empty comments? |
There is an explicit check here: I don't know what Github would do with an empty message I'm currently testing it it works here: |
Ah, I missed that, sorry! Hadn't had enough caffeine :) Would you mind just noting in the description that setting it to the empty string turns off the comment? If you're happy this works for your case, I'll merge it |
Not sure why but it posts empty quotes... |
Because we're passing the arguments through Github's YAML, then Docker, then bash, it's quite possible it's getting passed through as |
244d7eb
to
619636e
Compare
I've tested and added the part about disabling the comment. |
619636e
to
3023eb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @bwrsandman !
Implements #47