Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow not setting config file #96

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Allow not setting config file #96

merged 3 commits into from
Oct 11, 2023

Conversation

bwrsandman
Copy link
Contributor

@bwrsandman bwrsandman commented Oct 6, 2023 •
edited
Loading

Implementation and fixes #95

@ZedThree
Copy link
Owner

ZedThree commented Oct 9, 2023

Nice, thanks @bwrsandman! This looks like the simplest implementation. The test here needs updating though. It would be good to cover the four scenarios you lay out in #95.

@ZedThree ZedThree mentioned this pull request Oct 9, 2023
Closed
@ZedThree
Copy link
Owner

Thanks @bwrsandman !

@ZedThree ZedThree merged commit e3c07fc into ZedThree:master Oct 11, 2023
1 check passed
@bwrsandman bwrsandman deleted the empty-config branch October 11, 2023 11:50
@bwrsandman bwrsandman mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedThree ZedThree ZedThree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting not setting config file
2 participants
@bwrsandman @ZedThree