Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react navigation #2176

Merged
merged 6 commits into from
May 17, 2024
Merged

Conversation

myxmaster
Copy link
Contributor

@myxmaster myxmaster commented May 5, 2024

Description

Removed packages react-navigation and react-navigation-stack, use @react-navigation/native and @react-navigation/stack instead, updated @react-navigation/bottom-tabs. Fixed breaking changes and added types to navigation props.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@myxmaster myxmaster marked this pull request as draft May 5, 2024 18:51
@myxmaster
Copy link
Contributor Author

Found a minor regression: When using back-button while modal is displayed, modal is not closed, but background scren is navigating back.

@myxmaster
Copy link
Contributor Author

Fixed by creating back press handlers for every screen in App.tsx. Also improved back press handling when on lock screen so that navigation state is no more lost.

@kaloudis kaloudis added this to the v0.9.0 milestone May 17, 2024
@kaloudis kaloudis merged commit 127792e into ZeusLN:master May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants