Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending HTLCs view #2227

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Pending HTLCs view #2227

merged 5 commits into from
Jun 10, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jun 7, 2024

Description

Simulator Screenshot - iPhone 15 Plus - 2024-06-07 at 15 44 59

Simulator Screenshot - iPhone 15 Plus - 2024-06-07 at 22 31 23

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.0 milestone Jun 7, 2024
@kaloudis
Copy link
Contributor Author

kaloudis commented Jun 7, 2024

Added warnings and action items for embedded nodes:

Android:
simulator_screenshot_B2655B16-5919-480D-8303-33DFF1D40708

iOS:
simulator_screenshot_051C2711-761B-446E-8EEA-AAAC9B7EF386

@kaloudis kaloudis marked this pull request as ready for review June 7, 2024 02:04
@kaloudis
Copy link
Contributor Author

kaloudis commented Jun 7, 2024

Ping icon on Neutrino peers view changed to stop watch to avoid confusion

image

@kaloudis
Copy link
Contributor Author

kaloudis commented Jun 8, 2024

Added a pending HTLC indicator and subview to individual channels:

simulator_screenshot_01DB4FC6-7AE3-4464-B203-2612DE16DB18

simulator_screenshot_691B00C5-7C2D-49CE-BB85-B9101D69BAC1

simulator_screenshot_225B2888-B91E-429D-8F17-5BBC25CDA1DC

@kaloudis kaloudis merged commit 70529d2 into ZeusLN:master Jun 10, 2024
3 checks passed
@kaloudis kaloudis deleted the pending-htlcs branch June 10, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant